From a9c263df30929e92a6fd27f6bd01d2e7caf00699 Mon Sep 17 00:00:00 2001 From: EricEve Date: Wed, 4 Sep 2024 10:18:27 +0100 Subject: [PATCH] Fixed Enumerated Conversation Suggestion Bug The bug occurred when listing subtopics. Also updated version number for imminent 2.1.1 release --- actor.t | 17 ++++++++--------- docs/manual/changelog.htm | 5 ++++- modid.t | 2 +- readme.htm | 2 +- 4 files changed, 14 insertions(+), 12 deletions(-) diff --git a/actor.t b/actor.t index 8c73fe0..d49d773 100644 --- a/actor.t +++ b/actor.t @@ -1645,13 +1645,7 @@ modify Actor */ else if(tag not in (nil, 'all')) lst = lst.intersect(valToList(convKeyTab[tag])); - - /* - * Initialize the suggestion enumerator to clear out any leftover information from - * previous suggestion listings. - */ - suggestionEnumerator.initialize(); - + /* * Use the suggestedTopicLister to show a list of Suggested Topics * from the resulting list (lst). @@ -7199,7 +7193,12 @@ suggestedTopicLister: object } show(lst, explicit = true) - { + { + /* + * Initialize the suggestion enumerator to clear out any leftover information from + * previous suggestion listings. + */ + suggestionEnumerator.initialize(); /* * first exclude all items that don't have a name property, since * there won't be anything to show. @@ -7352,7 +7351,7 @@ suggestedTopicLister: object { /* * If the current topic entry wants to include a sayPrefix, - * displat the sayPrefix. In practice this only applies to + * display the sayPrefix. In practice this only applies to * SayTopics which may or may not want to introduce the name of a * suggestion with 'say'. */ diff --git a/docs/manual/changelog.htm b/docs/manual/changelog.htm index 1942cf6..16308cf 100644 --- a/docs/manual/changelog.htm +++ b/docs/manual/changelog.htm @@ -41,7 +41,7 @@

Change Log

  • Version 0.2
  • -

    Version 2.1.1 (tbd)

    +

    Version 2.1.1 (04-Sep-2024)

    Fixed an issue with the way the location of a MultiLoc is calculated when one of the locations of the MultiLoc is in a room visible from another room in the same SenseRegion and the actor is in that other room (previously this could result in the actor not being able to view the MultiLoc, even though it should have been possible).


    The message explaining how to toggle the enumeration and/or hyperlinking of conversation topic suggestions has been tidied up into a more compressed form. It has also been changed to use the notification style tag rather than the parser style tag, since this is more consistent with how these style tags are meant to be used. The same change has been applied to a couple of other messages, such as those for turning on and off the notification of score changes.

    @@ -63,6 +63,9 @@

    Version 2.1.1 (tbd)


    Fixed bug in the objDetached precondition (brackets were missing from a foreach loop).


    +

    Fixed bug with enumeration of subtopics when enumeration of topic suggestions is active.

    +
    +

    Version 2.1 (03-July-2024)

    The behaviour of the MoveTo action has be modified (with a small RISK OF AFFECTING EXISTING CODE). The previous behaviour could often prove counter-intuitive or confusing. The main purpose of the MOVE TO command was and is to allow notional relocation of objects to a particular vicinity within a room, e.g. so that the player might need to use the command MOVE CHAIR TO BOOKCASE before standing on the chair to reach the top shelf of the bookcase, in which case the chair's movedTo property becomes set to the bookcase (for game code to check). But this probably doesn't feel like the expected behaviour when the indirect object of a MOVE TO command is a container or surface. e.g. MOVE PEN TO BOX or MOVE BOOK TO SHELF, so now when the indirect object of a MOVE TO command is a container, the command will be converted to PUT IN and when it's a surface the command will be converted to PUT ON.

    diff --git a/modid.t b/modid.t index d2acd99..3622504 100644 --- a/modid.t +++ b/modid.t @@ -598,7 +598,7 @@ moduleAdv3Lite: ModuleID byline = 'by Eric Eve' htmlByline = 'by ' + 'Eric Eve' - version = '2.1.0.0.4 - 2024-08-19 13:35' + version = '2.1.1' /* * We use a listing order of 50 so that, if all of the other credits diff --git a/readme.htm b/readme.htm index 8793941..421d734 100644 --- a/readme.htm +++ b/readme.htm @@ -7,7 +7,7 @@
    -

    ADV3LITE VERSION 2.1

    +

    ADV3LITE VERSION 2.1.1

    Thank you for your interest in adv3Lite, an alternative library for use with the TADS 3 Interactive Fiction authoring system.