Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Button on Nodes #464

Open
bbertucc opened this issue Sep 9, 2024 · 5 comments
Open

Ignore Button on Nodes #464

bbertucc opened this issue Sep 9, 2024 · 5 comments
Assignees
Labels
bountied https://bbertucc.notion.site/Bug-Bounties-37cb0c61fb2d4bb984a78cc6e4b4aa56

Comments

@bbertucc
Copy link
Member

bbertucc commented Sep 9, 2024

Overview

We need an ignore button to mark nodes ignored. Users requested this because some of our scans report false positives. The button must log when an issue is ignored or unignored, similar to how a node is logged equalified or unequalified.

The ignore action should be done on a single property page, since it is a universal action.

We discussed either included a list of nodes on the property page, or a search that allowed you to search for nodes and add them of a list of ignored nodes. You should be also able to remove them from the ignored list. It may be helpful to include the time when a node was ignored.

That UX may be changed in Version 2.

Bountied

Since this is a bountied issue, Assignees should post an estimate that is then approved as per this note in the handbook: https://github.com/EqualifyEverything/handbook?tab=readme-ov-file#how-are-bounties-budgeted

@bbertucc bbertucc added this to the Sep 16 Sprint milestone Sep 9, 2024
@bbertucc bbertucc added the bountied https://bbertucc.notion.site/Bug-Bounties-37cb0c61fb2d4bb984a78cc6e4b4aa56 label Sep 9, 2024
@bbertucc
Copy link
Member Author

bbertucc commented Sep 9, 2024

Adding @heythisischris to budget work on this. He's open for anyone to pair with him.

@bbertucc
Copy link
Member Author

bbertucc commented Sep 9, 2024

We started to discuss this in #323. We decided not to include the explanation because it's seemingly penalizing users for using a feature. We don't want to create anti-user features like that. Plus, the user will have a record of when things were ignored or not.

@bbertucc
Copy link
Member Author

@heythisischris can you add an estimate to this?

@heythisischris
Copy link
Member

@bbertucc Yes I can- I estimate this will take between 4-8 hours. Let's start with 4 hours.

@bbertucc
Copy link
Member Author

Great! Approved @heythisischris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bountied https://bbertucc.notion.site/Bug-Bounties-37cb0c61fb2d4bb984a78cc6e4b4aa56
Projects
None yet
Development

No branches or pull requests

2 participants