Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleDates not showing active badge anymore #2796

Closed
3 tasks done
Liebeck opened this issue Apr 10, 2023 · 2 comments
Closed
3 tasks done

MultipleDates not showing active badge anymore #2796

Liebeck opened this issue Apr 10, 2023 · 2 comments

Comments

@Liebeck
Copy link

Liebeck commented Apr 10, 2023

Prerequisites

Describe the issue

Beginning with version 6.4.1 (and latest 6.4.4), the picker does not add the 'active' class to the clicked date anymore. This results in selected dates not being highlighted anymore. Downgrading to 6.2.9 revealed to me that my code is working and that the bug started in 6.4.1

Looking at the 6.4.1 diff, I can see this change 7b4622c#diff-2ba219d378add7c5eec0f4fed2e1599d032c4282b5b7546ac6aa7a1982c29890R109

@Eonasdan I think you flipped the boolean there. Instead of
!this.optionsStore.options.multipleDates &&
it should probably be
this.optionsStore.options.multipleDates &&
?

StackBlitz fork

none

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of are you using? You can find this information from the sample StackBlitz.

6.4.4

What your browser's locale? You can find this information from the sample StackBlitz.

de-DE

@Liebeck Liebeck added State: Triage Tickets that need to be triaged. Type: Bug labels Apr 10, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Tempus Dominus Apr 10, 2023
@Eonasdan Eonasdan added Area: TypeScript Priority: Medium and removed State: Triage Tickets that need to be triaged. labels Apr 21, 2023
@Eonasdan Eonasdan moved this from 🆕 New to 🏗 In progress in Tempus Dominus Apr 21, 2023
@Eonasdan Eonasdan moved this from 🏗 In progress to 👀 In review in Tempus Dominus Apr 22, 2023
@Eonasdan
Copy link
Owner

Hello 6.7.7 should resolve this.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Tempus Dominus Apr 22, 2023
@Eonasdan Eonasdan moved this from ✅ Done to 🚀 Released in Tempus Dominus Apr 22, 2023
@Liebeck
Copy link
Author

Liebeck commented Apr 22, 2023

@Eonasdan Thank you very much! ❤️ I can confirm that 6.7.7 fixes that issue.

FYI: You shipped a console.log(index) (https://github.com/Eonasdan/tempus-dominus/pull/2803/files#diff-9cb33452562adbb370a88113a5e9699d66b6b5715b51e88ff959d21f2fc34309R342) into the production build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants