Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time widget does not keep the time if the time is manually entered #2770

Closed
3 tasks done
lenamtl opened this issue Mar 10, 2023 · 1 comment
Closed
3 tasks done

Time widget does not keep the time if the time is manually entered #2770

lenamtl opened this issue Mar 10, 2023 · 1 comment

Comments

@lenamtl
Copy link

lenamtl commented Mar 10, 2023

Prerequisites

Describe the issue

Hi,

Here is a demo of the time picker standalone
https://jsfiddle.net/lenamtl/bh6dgLkv/

The actual settings:

  • time only
  • 24h format
  • be able to enter the time manually and use the widget by clicking the input or a button

Problem:
Time entered manually into the input is not kept when editing using the widget.

To reproduce
Enter any time manually let say 18:00
Open the time picker widget (using a button or by clicking on the input) is not diplaying 18:00 and it should be.
It display actual time instead of displaying 18:00

Note : I have tested the same case with date using the calendar widget and it kept the manually entered date.
So it should do the same for time.
This is standard, this is what does every time and date plugin.

This issue is the main reason why I'm not using this plugin and I hope this is going to be fixed soon.

*Any temporary solution is welcome

Thanks

StackBlitz fork

https://jsfiddle.net/lenamtl/bh6dgLkv/

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of are you using? You can find this information from the sample StackBlitz.

the latest

What your browser's locale? You can find this information from the sample StackBlitz.

en-us

@lenamtl lenamtl added the State: Triage Tickets that need to be triaged. label Mar 10, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Tempus Dominus Mar 10, 2023
@Eonasdan
Copy link
Owner

You'll notice that on your fiddle, that there's a warning on the console that useTwentyFour is deprecated.

Please update your config to include:

localization: {
    hourCycle: 'h23',
    format:'HH:mm'
 }

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Tempus Dominus Apr 10, 2023
@Eonasdan Eonasdan added State: Not a Bug and removed State: Triage Tickets that need to be triaged. labels Apr 10, 2023
@Eonasdan Eonasdan changed the title [Bug]Time widget does not kept the time if the time is manually entered Time widget does not keep the time if the time is manually entered Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants