Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombinedAdjointThunk should also return ret value #107

Closed
vchuravy opened this issue Jul 27, 2021 · 7 comments
Closed

CombinedAdjointThunk should also return ret value #107

vchuravy opened this issue Jul 27, 2021 · 7 comments
Labels
ABI help wanted Extra attention is needed

Comments

@vchuravy
Copy link
Member

julia> autodiff(f, Active(2.0))
(4.0,)

Should maybe be:

julia> (4.0, (4.0,))
(4.0, (4.0,))
@vchuravy
Copy link
Member Author

@tansongchen this might be a good place to start.

@vchuravy vchuravy added the help wanted Extra attention is needed label Sep 28, 2021
@tansongchen
Copy link
Collaborator

Just went though compiler.jl, this should be straightfoward. will do it

@tansongchen tansongchen self-assigned this Sep 28, 2021
@wsmoses
Copy link
Member

wsmoses commented Sep 30, 2021

Adding this as an option actually enables us to handle #112 by simply returning the shadow return via the corresponding shadow return arg.

@vchuravy
Copy link
Member Author

vchuravy commented Feb 3, 2023

@wsmoses #537 did implement this right?

@vchuravy vchuravy closed this as completed Feb 3, 2023
@wsmoses
Copy link
Member

wsmoses commented Feb 3, 2023

I don't think so, but it changed the ABI to have a place for this.

@wsmoses wsmoses reopened this Feb 3, 2023
@wsmoses
Copy link
Member

wsmoses commented Feb 3, 2023

Done in #598

@wsmoses wsmoses closed this as completed Feb 4, 2023
@wsmoses wsmoses mentioned this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants