Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Image URL source cache issue #967

Closed
vusters opened this issue Nov 9, 2023 · 0 comments
Closed

Fix Image URL source cache issue #967

vusters opened this issue Nov 9, 2023 · 0 comments
Assignees

Comments

@vusters
Copy link
Contributor

vusters commented Nov 9, 2023

We cache the image's URL so they can load faster the next time:

Image:
  source: https://example.com/1234

This seems to be a problem if the image has been updated at the URL (e.g. Profile photo changed and uploaded to the server). When we load this page again, the image still points to the old one since it was cached.

Please check:

  • check whether the image should be cached? as in if does the Image bust the cache if its http header says it has changed
  • If we can't cache the image by the http header, so we need a flag that say cache: false to force the image to be loaded every time?
@vusters vusters added this to Ensemble Nov 9, 2023
@vusters vusters converted this from a draft issue Nov 9, 2023
@fullstackctp fullstackctp moved this from Ready for Work to In Progress in Ensemble Nov 23, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Released in Ensemble Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

No branches or pull requests

3 participants