added moenage stuff #1787
Open
added moenage stuff #1787
+1,520
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snehmehta
requested changes
Dec 25, 2024
| final _errorMsg = "MoEngage module is not enabled. Please review the Ensemble documentation."; | ||
|
|
||
| MoEngageModuleStub() { | ||
| throw RuntimeError(_errorMsg); |
There was a problem hiding this comment.
Stubs initialise shouldn't be throwing module is not enabled error. This will run in every non moengage apps
| @@ -138,12 +154,15 @@ class NotificationManager { | |||
| } on Exception catch (e) { | |||
| print("NotificationManager: Error receiving notification: $e"); | |||
| } | |||
| print("----------"); | |||
There was a problem hiding this comment.
either convert it to debugPrint or remove it
| @@ -141,6 +141,7 @@ dependencies: | |||
| flutter_slidable: ^3.1.1 | |||
| accordion: ^2.6.0 | |||
| session_storage: ^0.0.1 | |||
| moengage_flutter: ^8.0.0 | |||
There was a problem hiding this comment.
make sure when you make a build for both android and IOS to test it does not need any app entitlement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: #1773
Right now creating script for Build system for all configurations related to updating gradle, manifest and kotlin files needed for moenage. Also for iOS.
Wot is implemented for Moenagage is: