Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging #129

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add logging #129

wants to merge 10 commits into from

Conversation

bilalebi
Copy link
Contributor

@bilalebi bilalebi commented Jul 6, 2023

JIRA Ticket

https://www.ebi.ac.uk/panda/jira/browse/EA-932

Changes

Log client info (Client IP, HTTP code and User Agent) to the stdout that will get processed by ELK

@bilalebi bilalebi self-assigned this Jul 6, 2023
Copy link
Collaborator

@kamaldodiya kamaldodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the end game here ?

@bilalebi
Copy link
Contributor Author

bilalebi commented Aug 29, 2023

What is the end game here ?

We would like to agree on a way to print logs in the stdout which will be parsed, processed and stored by ELK
It's still WIP, as I'm discussing with web Prod how best to approach this

@kamaldodiya
Copy link
Collaborator

parsed, processed and stored by ELK

Once it is parsed, processed and stored by ELK

  1. What answers it will give it about the graphql-core :) ( should stop saying it thoas ;) ) ?
  2. How it will help in understanding the operational aspect of the graphql-core ?

@bilalebi
Copy link
Contributor Author

  1. What answers it will give it about the graphql-core :) ( should stop saying it thoas ;) ) ?
  2. How it will help in understanding the operational aspect of the graphql-core ?
  • Client IP: Will give us an idea of the number of users
  • HTTP Status: Returns 200 if the query syntax is correct, 400 otherwise
  • User Agent: Would help us know where are requests coming from (e.g. browser, scripts..)

There is also the possibility to log the queries executed somewhere if we want to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants