Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional parameters from example models #499

Open
tsmbland opened this issue Sep 30, 2024 · 2 comments
Open

Remove optional parameters from example models #499

tsmbland opened this issue Sep 30, 2024 · 2 comments
Assignees

Comments

@tsmbland
Copy link
Collaborator

In #495 I went through the documentation and marked the parameters which are optional. Usually these parameters are only needed if using certain agent objectives.

To keep the example models and tutorials simple, I suggest that we remove these parameters and only include the parameters that are required for these models to run.

The main reason to do this is that most users start with the default model and add to it to build their own models. If a parameter (such as the CO2 emissions factor) is included in the default model, and the user doesn't understand that it's optional, they make go through considerable (and wasted) effort to find the appropriate value for any new component that they add, or be unnecessarily intimidated by the complexity of the model.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in MUSE Sep 30, 2024
@Jin-Jun-Mei
Copy link

Jin-Jun-Mei commented Oct 1, 2024

I agree that keep the tutorial simple will help users to build the model faster.

But I think there are some parameters that are necessary. For instance, you mentioned the "CO2 emissions factor." In my opinion, for an energy system model (that focused on low-carbon transitions), this is an important parameter. I would actually making the "CO2 emissions factor" a non-optional parameter for the model (MUSE). But then I realize that the emission factor is reflected already in the CommOut.csv, so the CommodityEmissionFactor_CO2 maybe redundant anyway....

/Jinxi

@tsmbland
Copy link
Collaborator Author

tsmbland commented Oct 1, 2024

Yeah, I'm not sure what the original intention of the CommodityEmissionFactor_CO2 parameter was, but it isn't used anywhere, in any circumstances, and the CommOut file has all the information MUSE needs about emissions.

@tsmbland tsmbland self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants