Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat formats will be killed off #31

Open
myrsloik opened this issue Aug 1, 2021 · 10 comments
Open

Compat formats will be killed off #31

myrsloik opened this issue Aug 1, 2021 · 10 comments

Comments

@myrsloik
Copy link

myrsloik commented Aug 1, 2021

The compat formats will be removed in future builds of VS meaning that you'll have to use RGB24 as output and pack the image yourself. You can get the beta builds with this behavior here:
https://forum.doom9.org/showthread.php?t=183070

@Endilll
Copy link
Owner

Endilll commented Aug 1, 2021

Thank you for letting me know.
Can Python API in those beta builds be considered stable? Can you give any estimates if it's not?
Again, any estimates for proper release with APIv4?
I'm interested not just in compat formats removed, but in audio support as well.

@myrsloik
Copy link
Author

myrsloik commented Aug 1, 2021

Can Python API in those beta builds be considered stable?

Yes, there are no further changes planned. Overall there are very few changes on the Python side apart from the minimum necessary due to core functionality differences.

Again, any estimates for proper release with APIv4?

A few weeks to a month I guess. Very few bugs reported so far and scripts/applications seem to get updated reasonably fast.

@Endilll
Copy link
Owner

Endilll commented Aug 1, 2021

Good news, thank you. I'll make sure to update vapoursynth-preview, and revisit audio support proof-of-concept I made against some early builds year and a half ago.

@shssoichiro
Copy link

Do you have an update on this? The breaking changes to vapoursynth have been out for a few weeks and are now pushed to the Arch repos. vspreview is completely broken with the new version.

@DJATOM
Copy link
Contributor

DJATOM commented Oct 2, 2021

@shssoichiro As temporary workaround you may use my patch (with libp2p plug-in).

@shssoichiro
Copy link

I'm still receiving the same error with that patch. To be specific, the error I'm getting is module 'vapoursynth' has no attribute 'AlphaOutputTuple' in core/types.py line 697.

@shssoichiro
Copy link

shssoichiro commented Oct 2, 2021

I'm trying to do some debugging locally. Looks like AlphaOutputTuple was renamed to VideoOutputTuple, but after fixing that, I hit another error. I'll keep going, hopefully eventually I'll have something working.

Is there a full migration guide from API3 to API4? I searched for one but could not find anything of the sort.

@shssoichiro
Copy link

@DJATOM It looks like these are the remaining fixes to get it to work: shssoichiro@5e8eb1f

@DJATOM
Copy link
Contributor

DJATOM commented Oct 2, 2021

Ah, indeed. I forgot to update for latest changes. Will make new patch soon.

@DJATOM
Copy link
Contributor

DJATOM commented Oct 2, 2021

Here comes updated patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants