fix(input): focus style missing on consumer apps #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will rely in the fallback values for default.
We just need to set different values for `ring-width`, `ring-offset-width` and `ring-color-focus`
Make sure to emit bqInput on clear action too.
dgonzalezr
force-pushed
the
fix/input-focus-styles
branch
from
1a2147f to
3ebaf26
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9c990a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
|
Kudos, SonarCloud Quality Gate passed!
|
endv-bogdanb
approved these changes
Jul 20, 2023
dgonzalezr
added a commit
that referenced
this pull request
Jul 20, 2023
- We made the focus inherit from Tailwind config focus, just need to set different values for `--bq-ring-width`, `--bq-ring-offset-width`, and `--bq-ring-color-focus`. - Make sure to emit `bqInput` on clear action too.
dgonzalezr
added a commit
that referenced
this pull request
Jul 20, 2023
- We made the focus inherit from Tailwind config focus, just need to set different values for `--bq-ring-width`, `--bq-ring-offset-width`, and `--bq-ring-color-focus`. - Make sure to emit `bqInput` on clear action too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--bq-ring-width,--bq-ring-offset-width, and--bq-ring-color-focus.bqInputon clear action too.