Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input): add new <bq-input> component #344

Merged
merged 41 commits into from
Jul 18, 2023
Merged

feat(input): add new <bq-input> component #344

merged 41 commits into from
Jul 18, 2023

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented Jul 7, 2023 •
edited
Loading

@dgonzalezr
Copy link
Collaborator Author

dgonzalezr commented Jul 7, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f4906e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@dgonzalezr dgonzalezr added the feature 🛠 New feature or request label Jul 10, 2023
@dgonzalezr dgonzalezr force-pushed the feat/input-component branch from 751e175 to 4c50a23 Compare July 12, 2023 16:30
@dgonzalezr dgonzalezr marked this pull request as ready for review July 17, 2023 11:34
dgonzalezr added 22 commits July 17, 2023 15:37
@dgonzalezr
feat(input): add component auto generated skeleton
05d69e0
@dgonzalezr
feat(input): add base styles and prefix/suffix slots
6b82061
@dgonzalezr
feat(input): handle prefix/suffix slots visibility
a6f08be
@dgonzalezr
refactor(input): use CSS variables and logical properties
b14ca76
@dgonzalezr
docs(input): update storybook examples
c0c91a2
@dgonzalezr
test(input): update e2e tests
030223e
@dgonzalezr
refactor(input): prefix/suffix to not use position absolute
7e47129
@dgonzalezr
feat(input): add clear button (only visual layout)
1af770a
@dgonzalezr
feat(input): handle change and clear input events
04c9ae4
@dgonzalezr
feat(input): allow hide the clear button with disableClear
fd40d78
@dgonzalezr
feat(input): add clearButtonLabel, used for accessibility
5f4aa3f
@dgonzalezr
refactor(input): rename CSS classes
04e8dc9
@dgonzalezr
feat(input): handle input label content
9aa7205
@dgonzalezr
fix(input): hasValue state on default value set
94d9496
@dgonzalezr
test(input): update e2e tests
bb45353
@dgonzalezr
fix(input): border color when the input is focused
4001266
@dgonzalezr
refactor(input): use CSS variables for label and helper text
7d4a267
@dgonzalezr
feat(input): add helper text
d8b8c9c
@dgonzalezr
docs(input): update storybook example with helper text
f6b956f
@dgonzalezr
test(input): add e2e test for helper-text
c81e2bc
@dgonzalezr
feat(input): hanlde input, focus and blur events
247bb00
@dgonzalezr
refactor: use shadow DOM delegatesFocus
96421a5
dgonzalezr added 16 commits July 17, 2023 15:37
@dgonzalezr
fix: wrong EventEmitter import path
51fadc1
@dgonzalezr
feat(input): allow and handle debounce for bqInput event
f46a2d7
@dgonzalezr
feat(input): handle validation status
104a0b1
@dgonzalezr
docs(input): add validation storybook examples
8d69098
@dgonzalezr
test(input): update e2e tests
da32223
@dgonzalezr
feat(input): handle disabled and move types
70f2310
@dgonzalezr
feat(input): support native HTML input attributes
54be510
@dgonzalezr
docs(input): update storybook examples
874552c
@dgonzalezr
feat(input): add bq-input to angular value accessor bindings
d970178
@dgonzalezr
fix(angular): cannot use private types
cd58365
@dgonzalezr
fix(tooltip): set display: flex on the trigger container
3888675
@dgonzalezr
fix(input): remove optional from autofocus prop
a67c93e
@dgonzalezr
docs(input): add label with tooltip example
08463f0 
Provide input general overview documentation (.mdx)
@dgonzalezr
docs(input): improve storybook conditonal templates
b859a9f
@dgonzalezr
docs(input): use ifDefined lit-html directive
afa234b
@dgonzalezr
style: sync package-lock.json after rebase
ff53d99
@dgonzalezr dgonzalezr force-pushed the feat/input-component branch from 322e61b to ff53d99 Compare July 17, 2023 12:38
@endv-bogdanb
Copy link
Collaborator

endv-bogdanb commented Jul 17, 2023 •
edited
Loading

For type="search"I think we should hide native x.
image

@dgonzalezr
Copy link
Collaborator Author

For type="search"I think we should hide native x. image

Good point, on it! 🙂

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dgonzalezr dgonzalezr merged commit 7ade1d7 into develop Jul 18, 2023
@dgonzalezr dgonzalezr deleted the feat/input-component branch July 18, 2023 09:09
dgonzalezr added a commit that referenced this pull request Jul 18, 2023
@dgonzalezr
feat(input): add new bq-input component (#344)
f8ca8bc
dgonzalezr added a commit that referenced this pull request Jul 18, 2023
@dgonzalezr
feat(input): add new bq-input component (#344)
6c4d288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamudeHomsi HamudeHomsi HamudeHomsi left review comments

@endv-bogdanb endv-bogdanb endv-bogdanb approved these changes

@amturian amturian Awaiting requested review from amturian

Assignees

@endv-bogdanb endv-bogdanb

Labels
feature 🛠 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgonzalezr @endv-bogdanb @HamudeHomsi