feat(Icon): deprecate weight property
#1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that, if the user did not used the setAssetPath() method, is using the internal SVG icons and the `/svg/` subpath will be added internally
We no longer need this property since the icon weight can be specify via name, e.g. `bell-fill`
This is not needed since the fill is set via attribute in the SVG tag
dgonzalezr
force-pushed
the
fix/icon-assets-path
branch
from
1bb6310 to
804fbcc
Compare
|
endv-bogdanb
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the
weightproperty on the Icon component. This property was added when we had the SVG assets split in a different folder by weight:thin,light,regular,fill,bold, andduotone, but the SVG assets have been merged into a single folder and the weight can now be set within the icon name itself, if before we could have:now we can archive the same by doing the following:
Also, we have improved the
setBasePath()and now users can specify even remote URLs in order to use a different icon libraryRelated Issue
N/A
Documentation
Screenshots (if applicable)
Checklist
Additional Notes
We have also added VSCode Anchors to highlight what needs to be removed in the future.