Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Divider): improve code readability and performance #1159

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented Jul 23, 2024

Description

This PR improves the code readability of the BqDivider, removes strokeDrawPositions from the global scope, and uses Map() instead of the Switch statement. It also replaces physical CSS values with logical properties to support the RTL layout content better.

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains label Jul 23, 2024
endv-bogdanb
endv-bogdanb previously approved these changes Jul 23, 2024
Copy link

@dgonzalezr dgonzalezr merged commit 5ab2149 into main Jul 23, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the refactor/divider branch July 23, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants