Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Side menu): use CSS logical properties instead of physical values #1157

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR refactors the CSS of the Side menu component, replacing CSS physical values with logical properties, to support RTL content layout.

CleanShot.2024-07-22.at.17.36.58.mp4

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains label Jul 22, 2024
Copy link

@dgonzalezr dgonzalezr merged commit 398d92f into main Jul 23, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the refactor/side-menu branch July 23, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants