Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icon): add --bq-icon--direction and flip SVG automatically for dir="rtl" #1156

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented Jul 19, 2024

Description

This PR adds the possibility to automatically flip the SVG icons horizontally when dir="rtl". We have added a global custom property --bq-icon--direction that can be also used by consumers when a BqIcon needs to be flipped.

CleanShot.2024-07-19.at.18.57.45.mp4

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the feature 🛠 New feature or request label Jul 19, 2024
Copy link

Copy link
Collaborator

@Cata1989 Cata1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgonzalezr dgonzalezr merged commit d7dd1b1 into main Jul 21, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the feat/icon-rtl-direction branch July 21, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🛠 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants