Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Slider): use CSS logical properties instead of physical values #1135

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

Cata1989
Copy link
Collaborator

@Cata1989 Cata1989 commented Jun 25, 2024

Description

The goal of this PR is to modernize the CSS by incorporating logical properties for improved adaptability and support for different writing modes.

Screenshot 2024-06-25 at 16 25 20
Screenshot 2024-06-25 at 16 24 27

It seems to be broken on the vertical side because all the calculations will differ from those on the horizontal side but with some minor changes through the code we can achieve this. 👇 (these changes have to be made by the developers - all the -translate-y-1/2 will become translate-x-1/2 on vertical mode with writing-mode: tb)

Screenshot 2024-07-01 at 16 57 08

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@Cata1989 Cata1989 force-pushed the refactor/slider-logical-properties branch from 590cd74 to 39004a0 Compare June 25, 2024 13:39
@Cata1989 Cata1989 force-pushed the refactor/slider-logical-properties branch 2 times, most recently from b849bf1 to 6c363b2 Compare July 8, 2024 14:52
@dgonzalezr dgonzalezr force-pushed the refactor/slider-logical-properties branch from d270946 to 9ae612f Compare July 17, 2024 06:47
Copy link

@dgonzalezr dgonzalezr merged commit 024c629 into main Jul 17, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the refactor/slider-logical-properties branch July 17, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants