Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: vite fails to resolve correctly @beeq/core/dist/* paths #1069

Closed
endv-bogdanb opened this issue May 25, 2024 · 2 comments · Fixed by #1077
Closed

Bug: vite fails to resolve correctly @beeq/core/dist/* paths #1069

endv-bogdanb opened this issue May 25, 2024 · 2 comments · Fixed by #1077
Assignees
Labels
bug 🐛 Something isn't working

Comments

@endv-bogdanb
Copy link
Collaborator

BEEQ package

beeq/react

BEEQ version

1.4.0

Current Behavior

✘ [ERROR] Missing "./dist/components/bq-accordion.js" specifier in "@beeq/core" package [plugin vite:dep-pre-bundle]

node_modules/@beeq/react/src/components.js:5:57:
  5 │ ...ineBqAccordion } from '@beeq/core/dist/components/bq-accordion.js';
    ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This error came from the "onResolve" callback registered here:

node_modules/esbuild/lib/main.js:1293:20:
  1293 │       let promise = setup({

Expected Behavior

Should not fail.

Steps to Reproduce

  1. npm create vite@latest
  2. Pick react with typescript with swc
  3. cd project && npm i
  4. npm i @beeq/{core,react}
  5. add this to App.tsx
import './App.css'
import { BqButton } from '@beeq/react'

function App() {
  return <BqButton />
}

export default App

Code Reproduction URL

No response

Your Environment

No response

Additional Information

No response

@endv-bogdanb endv-bogdanb added the bug 🐛 Something isn't working label May 25, 2024
@dgonzalezr
Copy link
Collaborator

Could this issue be related to the changes made in here #1059 ? 🤔

@endv-bogdanb
Copy link
Collaborator Author

Could this issue be related to the changes made in here #1059 ? 🤔

Yes, the issue is the "exports".

Screen.Recording.2024-05-27.at.14.47.39.mov

@dgonzalezr dgonzalezr moved this to In progress 🛠️ in BEEQ Design System May 30, 2024
@dgonzalezr dgonzalezr self-assigned this May 30, 2024
@dgonzalezr dgonzalezr moved this from In progress 🛠️ to Review 🔍 in BEEQ Design System May 30, 2024
@github-project-automation github-project-automation bot moved this from Review 🔍 to Done 🎉 in BEEQ Design System May 30, 2024
@dgonzalezr dgonzalezr moved this from Done 🎉 to Released 🚀 in BEEQ Design System Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
Status: Released 🚀
Development

Successfully merging a pull request may close this issue.

2 participants