Skip to content

Commit

Permalink
more tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
EndangeredMassa committed Jan 2, 2024
1 parent 0752768 commit a6f5e06
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 17 deletions.
12 changes: 11 additions & 1 deletion app/article-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,17 @@ let articles =
"published": true,
"title": "Detangling the Standup: Status Reports, Team Planning, Context Sharing, and Community Building",
"date": "2022-01-04",
"description": "Standups are often applied without understanding the problem they are solving. This leads to:<br><br>1. Not clearly solving a specific problem<br>2. Not solving a problem with the best solution<br>3. A daily interruption to deep work<br><br>What follows is a pragmatic and ideal approach to resolving this situation. The pragmatic approach is to understand so you can excel within that system. The ideal solution tries to change the system to better serve the team."
"description": `Standups are often applied without understanding the problem they are solving. This leads to:
<br>
<ol>
<li>Not clearly solving a specific problem</li>
<li>Not solving a problem with the best solution</li>
<li>A daily interruption to deep work</li>
</ol>
What follows is a pragmatic and ideal approach to resolving this situation.
The pragmatic approach is to understand so you can excel within that system.
The ideal solution tries to change the system to better serve the team.
`
},
{
"slug": "detangling-the-manager",
Expand Down
16 changes: 9 additions & 7 deletions app/components/article-card.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ import { LinkTo } from '@ember/routing';

<template>
<div class="blog-item">
<LinkTo class="post-link"
@route="article"
@model={{@article}}>
{{@article.title}}
</LinkTo>
<p class="meta"><i>{{{@article.description}}}</i></p>
<p class="meta">{{@article.date}}</p>
<h2>
<LinkTo class="post-link"
@route="article"
@model={{@article}}>
{{@article.title}}
</LinkTo>
</h2>
<p class="meta"><i>{{@article.date}}</i></p>
<p class="meta">{{{@article.description}}}</p>
</div>
</template>
6 changes: 3 additions & 3 deletions app/components/article-header.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { LinkTo } from '@ember/routing';

<template>
<div class="blog-item">
<h1>
<h2>
{{@article.title}}
</h1>
<p class="meta">{{@article.date}}</p>
</h2>
<p class="meta"><i>{{@article.date}}</i></p>
</div>
</template>
19 changes: 19 additions & 0 deletions app/styles/app.css
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,25 @@ blockquote p:last-child {
margin-bottom: 0;
}

/*
TODO: these h2 styles have to move up to h1 styles because of the markdown rendering
TODO: move the title to not an h1, then move these styles to h1
*/

.blog-item h2 a {
font-size: 1.6rem;
}

.blog-item h2 {
color: var(--accent);
margin-bottom: 0.4rem;
font-size: 2.6rem;
}

.blog-item p {
margin-top: 0;
}

/* Icons from: https://www.iconfinder.com/iconsets/font-awesome-brands-vol-1 */
.icon-button {
text-decoration: none;
Expand Down
6 changes: 0 additions & 6 deletions app/templates/article/conventional-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@ This process helps convey understanding of:

You can use the process [as documented by the author](https://conventionalcomments.org/), but I like using the following the following customized version.

```js
let a = 3;
console.log(a);
console.log('hey there');
```

## Streamlined Conventional Comments

All comments must be resolved before merging, but resolution can look different for different kinds of comments.
Expand Down

0 comments on commit a6f5e06

Please sign in to comment.