module-getter rule false positive

[keirlawson]

This rule is getting triggered for the following code:

const MODULE_NAME = 'mymodule';

angular
  .module(MODULE_NAME, [])
  .service('backendService', BackendService);

[EmmanuelDemey]

Thanks @keirlawson

Could you send a PR with a failing unit test ? ;)

Manu

[vrockai]

There seem to be another false positive for this rule, should I create a new issue for that? It happens when an object has the config method, like:

/** @ngInject */
function lazyLoadDebugConfig($ocLazyLoadProvider) { 
  $ocLazyLoadProvider.config({
    debug: false
  });
}

The ESLint errors than go like this:

  3:1  error  Avoid using a variable and instead use chaining with the getter syntax  angular/module-getter
  3:1  error  You should use the function syntax for DI                               angular/di

[kuhnroyal]

Same here:

$localForageProvider.config({
    driver: 'localStorageWrapper',
    name: 'test',
    storeName: 'test'
});

[EmmanuelDemey]

I solved the first issue. But the last 2, I do not know how we can solve it.
The problem is the config method. We can not detect that your providers is not an angular module easily.

[EmmanuelDemey]

I close this issue. See #223