Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to integration test components that use an fm-form #19

Closed
blimmer opened this issue Jun 5, 2015 · 3 comments
Closed

Difficult to integration test components that use an fm-form #19

blimmer opened this issue Jun 5, 2015 · 3 comments

Comments

@blimmer
Copy link
Collaborator

blimmer commented Jun 5, 2015

With the new component integration tests, it's easier to give a component access to a container for testing. However, the current way the initializer is set up, it requires an application to be present, which isn't available in a unit test.

I think this could be solved by using an instance-initializer and calling register and injection on the instance that gets passed through. For instance, check out how ember-i18n does this.

The thing that I'm not sure about is how you could make this backwards compatible for pre 1.12 Ember apps.

@Emerson
Copy link
Owner

Emerson commented Jun 5, 2015

Hmm, I'll look into this, but the documentation seems a little thin right now. Also not sure the best way to maintain backwards compatibility.

@blimmer
Copy link
Collaborator Author

blimmer commented Jun 5, 2015

In Ember I18n he has both an initializer and an instance-initializer (the initializer flavor just imports and calls the instance-intiailizer). I think this is how he manages backwards compatibility.

@Emerson
Copy link
Owner

Emerson commented Oct 14, 2015

Think this issue is resolved! Moved the latest version over to a service based approach for customizations. Would love to know if this made your life easier (if you're still even using this library)

@Emerson Emerson closed this as completed Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants