calculate fees #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use enum gaspricelevel instead of hardcoded string
import types
…r/fee-req-res-type
eitjuh
suggested changes
Mar 24, 2022
There was a problem hiding this comment.
Building this results in errors:
src/routes/fees.ts:13:30 - error TS2495: Type '{ gasPriceLevel: GasPriceLevel; tx: any; }' is not an array type or a string type.
13 for (const feesRequest of request.body){
~~~~~~~~~~~~
src/routes/fees.ts:23:15 - error TS2345: Argument of type 'any[]' is not assignable to parameter of type '{ gasUsed: string; fee: StaticArray<TObject<{ denom: TString; amount: TString; }>>; totalUSD: number; }'.
Type 'any[]' is missing the following properties from type '{ gasUsed: string; fee: StaticArray<TObject<{ denom: TString; amount: TString; }>>; totalUSD: number; }': gasUsed, fee, totalUSD
23 reply.send(response)
~~~~~~~~
Found 2 errors.
| import EmerisSigner from '@emeris/signer'; | ||
| import emerisMapper from '@emeris/mapper'; | ||
| import { AminoMsg } from "@cosmjs/amino"; | ||
| import ChainConfig from "../chainConfig"; | ||
| import FeeService from '../services/fees.service' |
There was a problem hiding this comment.
Can we rename the file to feeService so it matches with the class and all the other files?
|
What's the status here? |
It's on hold for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6, closes: #8
Prerequisite: publishing EmerisHQ/emeris-libraries#48
Approx calculations:
57135 * 0.03 (high) = 1714.05
1714.05 * 26 (atom) = 44565 ~ (0.04 * 10^6)
Req used for testing. (Change the port in the curl) -
No gasPriceLevel, all 3 levels (low, average, high)
Response:
[{"gasUsed":"57135","fee":[{"denom":"uatom","amount":"571.35"}],"totalUSD":0.015664},{"gasUsed":"57135","fee":[{"denom":"uatom","amount":"285.675"}],"totalUSD":0.00783},{"gasUsed":"57135","fee":[{"denom":"uatom","amount":"1714.05"}],"totalUSD":0.046982},{"gasUsed":"57135","fee":[{"denom":"uatom","amount":"571.35"}],"totalUSD":0.015661},{"gasUsed":"57135","fee":[{"denom":"uatom","amount":"1714.05"}],"totalUSD":0.046982}]