Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't factor in chains that are down for dex-agg swaps #1846

Open
fl-y opened this issue Jun 8, 2022 · 0 comments
Open

Don't factor in chains that are down for dex-agg swaps #1846

fl-y opened this issue Jun 8, 2022 · 0 comments
Labels
bug P? Bug without impact estimated

Comments

@fl-y
Copy link
Contributor

fl-y commented Jun 8, 2022

Describe the bug
Despite Osmosis chain being down, the dex-agg acted as if the dex was available.
Not an issue atm since we only have one dex integrated and the tx will fail anyway with the right error message.
However, will be an issue when we have multiple dexes integrated and the dex-agg recommends unavailable swaps.

To Reproduce
(Applicable since Osmosis is down at the time of writing)
Input corresponding values to the swap widget and see osmosis swaps being used.

Expected behavior

  • Swap widget not displaying swaps if Osmosis is down & Osmosis is the only dex.
  • Swap widget not using dexes that are down when there are multiple

Additional context
Slack thread

@fl-y fl-y added the bug P? Bug without impact estimated label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P? Bug without impact estimated
Projects
None yet
Development

No branches or pull requests

1 participant