Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Caching #789

Open
lukitsbrian opened this issue May 17, 2022 · 1 comment
Open

Improve Caching #789

lukitsbrian opened this issue May 17, 2022 · 1 comment

Comments

@lukitsbrian
Copy link
Contributor

lukitsbrian commented May 17, 2022

There are a few locations where we can imrpove caching, such as on the api-server and sdk-service

Within sdk-service, we can cache all the responses for incoming requests for ~7 seconds, which is similar to the block time for most cosmos-sdk chains.

In the api-server, we can try fetching cached requests before attempting to fetch them from sdk-service.

@Pitasi
Copy link
Contributor

Pitasi commented May 19, 2022

Within sdk-service, we can cache all the responses for incoming requests for ~7 seconds, which is similar to the block time for most cosmos-sdk chains.

yes, makes sense

In the api-server, we can try fetching cached requests before attempting to fetch them from sdk-service.

wdym? You want to add a cache for sdk-service responses in api-server too? I would only cache them in sdk-service for avoiding too much complexity. Since we use a persistent gRPC connection between api-server and sdk-service, if sdk-service can answer from memory the overhead of this roundtrip should be really small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants