Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit versioning of shared libraries #374

Closed
sgerogia opened this issue Jan 10, 2022 · 2 comments
Closed

Explicit versioning of shared libraries #374

sgerogia opened this issue Jan 10, 2022 · 2 comments

Comments

@sgerogia
Copy link
Contributor

sgerogia commented Jan 10, 2022

Atm the shared libraries (utils, models) have implicit versioning.
If a merged change is not backwards compatible, it will cause downstream code to break immediately.

DoD

  • Introduce an explicit SemVer GHA (e.g. this one) in both libraries. This will create automatic versions based on PR labels.
  • It is triggered on merge
  • Create the first explicit version in both libraries
  • Notify other team members
@0xmuralik
Copy link
Contributor

0xmuralik commented Jan 13, 2022

@sahith-narahari
Copy link
Contributor

We should update versions on existing repos too as part of this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants