From 0d606126135c84e90cb045ad6cb90e77ac65843f Mon Sep 17 00:00:00 2001 From: Ember Date: Thu, 18 Jan 2024 04:55:04 +1100 Subject: [PATCH 1/2] ehhhh --- .../admin/export_domain_blocks_controller_spec.rb | 6 +++--- spec/fixtures/files/domain_blocks.csv | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/controllers/admin/export_domain_blocks_controller_spec.rb b/spec/controllers/admin/export_domain_blocks_controller_spec.rb index 765b5b3a3af0dc..1c2d2454bc4e2e 100644 --- a/spec/controllers/admin/export_domain_blocks_controller_spec.rb +++ b/spec/controllers/admin/export_domain_blocks_controller_spec.rb @@ -19,10 +19,10 @@ describe 'GET #export' do it 'renders instances' do - Fabricate(:domain_block, domain: 'bad.domain', severity: 'silence', public_comment: 'bad server', private_comment: '') + Fabricate(:domain_block, domain: 'bad.domain', severity: 'silence', public_comment: 'bad server', private_comment: 'noop') Fabricate(:domain_block, domain: 'worse.domain', severity: 'suspend', reject_media: true, reject_reports: true, public_comment: 'worse server', private_comment: 'worse server :(', obfuscate: true) - Fabricate(:domain_block, domain: 'reject.media', severity: 'noop', reject_media: true, public_comment: 'reject media and test unicode characters ♥', private_comment: '') - Fabricate(:domain_block, domain: 'no.op', severity: 'noop', public_comment: 'noop', private_comment: '') + Fabricate(:domain_block, domain: 'reject.media', severity: 'noop', reject_media: true, public_comment: 'reject media and test unicode characters ♥', private_comment: 'noop') + Fabricate(:domain_block, domain: 'no.op', severity: 'noop', public_comment: 'noop', private_comment: 'noop') get :export, params: { format: :csv } expect(response).to have_http_status(200) diff --git a/spec/fixtures/files/domain_blocks.csv b/spec/fixtures/files/domain_blocks.csv index 5ad0353443c09b..c62df2e0c75ecd 100644 --- a/spec/fixtures/files/domain_blocks.csv +++ b/spec/fixtures/files/domain_blocks.csv @@ -1,4 +1,4 @@ #domain,#severity,#reject_media,#reject_reports,#public_comment,#private_comment,#obfuscate -bad.domain,silence,false,false,bad server,false +bad.domain,silence,false,false,bad server,noop,false worse.domain,suspend,true,true,worse server,worse server :(,true -reject.media,noop,true,false,reject media and test unicode characters ♥,false +reject.media,noop,true,false,reject media and test unicode characters ♥,noop,false From 5b0f546436b8d177eb5506ac87fdb774d3a4ae77 Mon Sep 17 00:00:00 2001 From: Ember Date: Mon, 22 Jan 2024 22:41:18 +1100 Subject: [PATCH 2/2] remove extra react button --- .../flavours/glitch/components/status_action_bar.jsx | 5 ----- 1 file changed, 5 deletions(-) diff --git a/app/javascript/flavours/glitch/components/status_action_bar.jsx b/app/javascript/flavours/glitch/components/status_action_bar.jsx index 6681dc6c097045..df1f893b808225 100644 --- a/app/javascript/flavours/glitch/components/status_action_bar.jsx +++ b/app/javascript/flavours/glitch/components/status_action_bar.jsx @@ -338,11 +338,6 @@ class StatusActionBar extends ImmutablePureComponent { : reactButton } - { - permissions - ? - : reactButton - } {filterButton}