Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pass on example shader and vk example-runner #109

Merged
merged 16 commits into from
Oct 30, 2020
Merged

Cleanup pass on example shader and vk example-runner #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
904d0a2
- get rid of vertex buffers in example
fu5ha Oct 22, 2020
cb4da77
remove depth buffer
fu5ha Oct 23, 2020
4ebfa94
use SRGB surface
fu5ha Oct 23, 2020
c57c642
improve tonemapping
fu5ha Oct 23, 2020
d665e90
make clippy happy
fu5ha Oct 23, 2020
413c53f
move tonemapping out of sky(), rename gl_pos to builtin_pos
fu5ha Oct 28, 2020
4336822
rename shaders and use sky shader in wgpu example runner
fu5ha Oct 28, 2020
1920c6f
apply srgb OETF and invert clip space for cpu example runner
fu5ha Oct 28, 2020
439f711
restructure example directory structure according to #170
fu5ha Oct 29, 2020
e00a77d
update winit in wgpu example runner
fu5ha Oct 29, 2020
84f53e1
fix deny.toml example crate refs
fu5ha Oct 29, 2020
01a2b76
example-shader -> sky-shader in docs
fu5ha Oct 29, 2020
ddd0397
update sky shader image
fu5ha Oct 29, 2020
22a8b4d
fix ci clippy script
fu5ha Oct 30, 2020
102764b
actually fix clippy due to #186 hopefully
fu5ha Oct 30, 2020
fffeafd
re-enable clippy and make it happy
fu5ha Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/clippy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ clippy spirv-builder

# Examples

# disabled due to https://github.com/EmbarkStudios/rust-gpu/issues/186
#clippy examples/example-runner
clippy examples/runners/ash
clippy examples/runners/wgpu

clippy examples/wgpu-example-runner

clippy_no_features examples/example-runner-cpu
clippy_no_features examples/example-shader
clippy_no_features examples/wgpu-example-shader
clippy_no_features examples/runners/cpu
clippy_no_features examples/shaders/sky-shader
clippy_no_features examples/shaders/simplest-shader
10 changes: 5 additions & 5 deletions .github/workflows/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ cargo_test spirv-builder
# Examples
# See: https://github.com/EmbarkStudios/rust-gpu/issues/84
if [[ -z "${CI}" && "$os" != "macOS" ]]; then
cargo_test examples/example-runner
cargo_test examples/runners/ash
fi

cargo_test examples/wgpu-example-runner
cargo_test examples/runners/wgpu

cargo_test_no_features examples/example-runner-cpu
cargo_test_no_features examples/example-shader
cargo_test_no_features examples/wgpu-example-shader
cargo_test_no_features examples/runners/cpu
cargo_test_no_features examples/shaders/sky-shader
cargo_test_no_features examples/shaders/simplest-shader
Loading