Propagate previously registered scopes when creating GlobalFrameView #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalFrameView might be created after some scopes were already registered and frame sink won't see them without prior propagation with GlobalProfiler::emit_scope_snapshot().
Checklist
Description of Changes
I've modified init function of GlobalFrameView so that it calls GlobalProfiler::emit_scope_snapshot() after the frame sink is registered so that it can see previously registered scopes.
Related Issues
I've noticed this issue when trying to render profiler UI conditionally with being disabled by default and in result scopes that were registered before the first call to the
GlobalProfiler::new_frame()
were not propagated to the frame sink that was registered afterwards.Simple reproduction code: