Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puffin_egui v0.27 does not create scopes in non-release mode. #204

Open
C0D3-M4513R opened this issue Apr 12, 2024 · 2 comments
Open

Puffin_egui v0.27 does not create scopes in non-release mode. #204

C0D3-M4513R opened this issue Apr 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@C0D3-M4513R
Copy link

C0D3-M4513R commented Apr 12, 2024

Describe the bug
A clear and concise description of what the bug is.
The puffin_egui flamegraph doesn't display correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Make an egui native app, that has puffin scopes and allows you to interact with the puffin_egui ui.
  2. Run the app and open the debugger.

Expected behavior
A clear and concise description of what you expected to happen.
I expected the flamegraph to show, like in previous versions.

Screenshots
If applicable, add screenshots to help explain your problem.

Device:

  • OS: [e.g. iOS] NixOs
  • Browser [e.g. chrome, safari] Using Native App, not browser.
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
image
app code here: https://github.com/C0D3-M4513R/unnamed-artnet-orion-vrsl-app/commit/41bb2cf38b82a001a9e549b6ee3841a8695c85cc (needs feature puffin, to display debugging menu)
(call to draw the window here: https://github.com/C0D3-M4513R/unnamed-artnet-orion-vrsl-app/blob/41bb2cf38b82a001a9e549b6ee3841a8695c85cc/app/src/app.rs#L405
)

@C0D3-M4513R C0D3-M4513R added the bug Something isn't working label Apr 12, 2024
@C0D3-M4513R C0D3-M4513R changed the title Puffin_egui v0.27 not displaying flamegraph correctly Puffin_egui v0.27 does not display the flamegraph correctly Apr 12, 2024
@C0D3-M4513R
Copy link
Author

C0D3-M4513R commented Apr 23, 2024

I narrowed it down to puffin not creating any scopes in non-release mode.

Edit: I can't even get it to consistently work on release mode.
I got it to work two times, by creating a profile scope in my update method.
When I tried replicating that, after it broke again, it did not work.
Idk what's up with this, but the flame graph and scopes just refuse to work consistently for me.

Edit: I got it to work consistently now. (https://github.com/C0D3-M4513R/unnamed-artnet-orion-vrsl-app/commit/a7e892bdd18081cb09a5c9a415fcaf4432404e22)
However in debug mode, only the first frame after enabling the profiler (puffin::set_scopes_on) has a flamegraph.

@C0D3-M4513R C0D3-M4513R changed the title Puffin_egui v0.27 does not display the flamegraph correctly Puffin_egui v0.27 does not create scopes in non-release mode. Apr 23, 2024
@emilk
Copy link
Collaborator

emilk commented Jul 31, 2024

Please check out the repo and run cargo r --example eframe. It should show you some profile scopes even without --release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants