Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ban: force using workspace dependencies when more than one crate depends on them #525

Closed
jaskij opened this issue Jul 3, 2023 · 0 comments · Fixed by #673
Closed
Labels
enhancement New feature or request

Comments

@jaskij
Copy link

jaskij commented Jul 3, 2023

Is your feature request related to a problem? Please describe.
In workspace projects, it's easy for crate dependencies to go out of sync.

Describe the solution you'd like
Add a new check which would trigger whenever crates in the workspace depend on the same crate, without using workspace dependencies. Perhaps also disallowing version-related fields (version and rev) in crate level Cargo.toml files.

Describe alternatives you've considered

Currently, I'm using the multiple-versions ban to ensure dependencies don't go out of sync, but it has a much larger reach than required, requiring extra maintenance. To that end, a new configuration for multiple-versions, which only checks direct dependencies of project crates would work well enough.

Additional context
nothing to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant