Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing warning when x11-dl changed license #119

Closed
repi opened this issue Jan 26, 2020 · 3 comments
Closed

Confusing warning when x11-dl changed license #119

repi opened this issue Jan 26, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@repi
Copy link
Contributor

repi commented Jan 26, 2020

x11-dl just changed from CC0-1.0 license in v2.18.4 to MIT in v2.18.5, which is great. We generally do not allow CC0-1.0 licenses so we didn't have it in our license allow list but instead had an explicit exception for it like this:

exceptions = [
    { allow = ["CC0-1.0"], name = "x11-dl" },
]

But then when we upgraded to the latest x11-dl that used MIT license (which is in our allow list) I got the following quite confusing warning:

image

MIT is in the allow list so this sounded quite strange. Removing the above exception line for x11-dl 's old CC0-1.0 license fixed this warning though.

I would have expected when updating the crate to get a warning instead of an unused license exception for x11-dl with CC0-1.0.

@Jake-Shadle
Copy link
Member

The allow list for exceptions is the only one used because they tend to be unique single licenses, but would be easy to have them be in addition to the global ones and then give a warning if the additional ones then weren't actually used

@repi
Copy link
Contributor Author

repi commented Jan 26, 2020

Ah so the exceptions actually overrules the allow list for a crate? Yeah that is rather cryptic

@Jake-Shadle Jake-Shadle added the bug Something isn't working label Feb 13, 2020
@Jake-Shadle
Copy link
Member

See #135 for the underlying issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants