Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fast_jsonapi dependency #16

Closed
EmCousin opened this issue Dec 17, 2019 · 6 comments · Fixed by #23
Closed

Update fast_jsonapi dependency #16

EmCousin opened this issue Dec 17, 2019 · 6 comments · Fixed by #23

Comments

@EmCousin
Copy link
Owner

EmCousin commented Dec 17, 2019

Following Netflix/fast_jsonapi#433, it appears that Netflix is no longer maintaining fast_jsonapi. A fork has been initiated and seems to be well maintained and up-to-date.

Let's update the fast_jsonapi dependency of this gem so that it points to this fork, and ensure nothing is broken in the process.

@goalaleo
Copy link

@EmCousin any news on this switch?

@EmCousin
Copy link
Owner Author

@goalaleo Didn't have much time to take care of it these last few months. Pandemic and all that. I'll see if I can start something this week, but feel free to provide a PR if you already have something

@vesan
Copy link
Contributor

vesan commented Nov 26, 2020

@EmCousin The fork seems to be the new official choice. Is there something stopping from changing this gem to use it?

@EmCousin
Copy link
Owner Author

@vesan I pushed a PR, I still need to make the build pass.
Feel free to give it a review if you have time, I would appreciate it. Thanks!

@EmCousin
Copy link
Owner Author

EmCousin commented Nov 27, 2020

This PR is now merged into master and the gem has been renamed to grape-jsonapi.
It is published to RubyGems here and Github Packages there

@vesan
Copy link
Contributor

vesan commented Nov 28, 2020

Thanks a ton! Check the PR now and looked good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants