Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepOpen is improperly handled in the generated code. #31

Closed
AraHaan opened this issue Dec 8, 2022 · 0 comments · Fixed by #32
Closed

KeepOpen is improperly handled in the generated code. #31

AraHaan opened this issue Dec 8, 2022 · 0 comments · Fixed by #32

Comments

@AraHaan
Copy link
Contributor

AraHaan commented Dec 8, 2022

Issue Details

Currently the generated code should dispose the underlying disposables only when the keep open property is false, however the generated code ends up doing it when it's true instead.

Describe the bug
Currently the generated code should dispose the underlying disposables only when the keep open property is false, however the generated code ends up doing it when it's true instead.

To Reproduce
There is not much to reproducing it if the type is a stream.

Expected behavior
For the underlying streams inside of a stream to be disposed when instructing the stream to not keep it open (not when it is instructed to keep it open).

Actual behavior
It disposes of the underlying stream at the wrong time.

Screenshots
image

Version used
The latest version on nuget.org.

Additional context
N/a.

This was referenced Dec 8, 2022
@AraHaan AraHaan mentioned this issue Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant