Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
train_iters * seqlen * gradient_accumulation_steps * micro_batch_size * world_size > 2147483647
our dataloader'ssample_idx
overflows leading to the cryptic error:Which will happen once the torch dataloader reaches the overflowed
sample_idx
. Simply storing tonp.int64
instead ofnp.int32
will do the job, but will waste memory and disk. I added a simple switch between the defaultint32
and newint64
dataset builders and tested it works.