Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerswap can't read CLN >24.08 listconfig output #320

Closed
grubles opened this issue Oct 1, 2024 · 0 comments · Fixed by #321
Closed

peerswap can't read CLN >24.08 listconfig output #320

grubles opened this issue Oct 1, 2024 · 0 comments · Fixed by #321
Labels
deprecated cln api Related to CLN API deprecations

Comments

@grubles
Copy link
Collaborator

grubles commented Oct 1, 2024

In CLN >24.08, the listconfig structure has changed causing peerswap to misread the allow-deprecated-apis field as false.

When that field is set to false, peerswap exits and print a log message explaining why. Since peerswap can't currently read the new API structure, it will always exit. We should update how peerswap (or more appropriately glightning?) reads CLN's listconfig.

"Instead of direct members with names equal the config variable, there's now a configs sub-object containing a member with details of each config setting1"

Footnotes

  1. https://docs.corelightning.org/docs/deprecations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated cln api Related to CLN API deprecations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant