Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightningd crashes because of log messages #4385

Closed
sgeisler opened this issue Feb 14, 2021 · 2 comments · Fixed by #4350
Closed

lightningd crashes because of log messages #4385

sgeisler opened this issue Feb 14, 2021 · 2 comments · Fixed by #4350
Labels
state::fixed These issues should have been addressed. Pending confirmation by OP, will close soon otherwise
Milestone

Comments

@sgeisler
Copy link
Contributor

Issue and Steps to Reproduce

I noticed that lightningd was crashing quite often recently and it felt like it was getting worse over time. It always happens right after some error complaining about a malformed JSON reply which obviously is a log message, e.g.:

Feb 14 23:33:58 [redacted] lightningd[10539]: offers: Malformed JSON reply '2021-02-14T22:33:58.047Z DEBUG   hsmd: Client: Received message 10 from client

or after turning off debug output

Feb 14 23:34:58 [redacted] lightningd[11514]: offers: Malformed JSON reply '2021-02-14T22:34:58.361Z INFO    plugin-fetchinvoice: Killing plugin: offers not enabled in config

Directly following it there's also a json dump of node config I assume, I can provide that privately if that helps.

After changing the log level to log-level=warn it seems to work better now (ran for 15min without crashing).

getinfo output

Not doxing myself here, but can of course send it, although I don't think it would help in this case.

I'm running v0.9.3 (015ac37) on debian 10.8 and disabled all plugins for debugging.

@cdecker
Copy link
Member

cdecker commented Feb 16, 2021

This is a known issue if you do not provide a --log-file and --daemon. We close the stdout file-descriptor which gets reused for plugins, leading to this issue.

It has been addressed in master: #4350

@cdecker cdecker added the state::fixed These issues should have been addressed. Pending confirmation by OP, will close soon otherwise label Feb 16, 2021
@cdecker cdecker added this to the v0.9.4 milestone Feb 16, 2021
@cdecker cdecker linked a pull request Feb 16, 2021 that will close this issue
@sgeisler
Copy link
Contributor Author

sgeisler commented Feb 16, 2021

Oh, sorry, somehow I didn't find that issue 😞 nice to see it's already fixed! 😃

@cdecker cdecker closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state::fixed These issues should have been addressed. Pending confirmation by OP, will close soon otherwise
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants