-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add closure
details to listpeers
and channel_state_changed
hook
#4027
Comments
@cdecker
|
In my opinion this would require add a simple enum to the notification params like: enum channel_state_change_reason {
CSCR_UNKNOWN, /* anything other than the reasons below */
CSCR_ONCHAIN, /* something happened onchain that forces us to change the state */
CSCR_USER, /* the operator or a plugin opened or closed a channel by 'hand' */
CSCR_LOCAL, /* known internal reasons, i.e. a failed HTLC */
CSCR_REMOTE /* the remote bilateral close or funded a channel with us */
}; What do you think of such a generic approach that categorizes the reasons? Also I think it might be necessary to add this to the |
Can be closed |
ACK close 🎻 |
Yessir 🙃 |
One of the recurring things we get asked for is "why was this channel closed?"
to which we usually just point to logs, that may not be present anymore due to
a restart. @ZmnSCPxj proposed adding a
closure
reason in [#4020] that'dcontain the cause of a channel closure (or more generally a state change) to
the
listpeers
result and to thechannel_state_changed
hook. I think thiscould go a long way towards helping users perform cause analysis for any
unexpected closure.
Open Questions
unilateral close, feerate adjustment, HTLC addition / removal. Arguably
the latter two might be too detailed and cause a lot of overhead /
noise in the status listing.
we should create a single
chanenl_state_change
table that covers allpossible fields, and not multiple tables.
much overhead (feerate adjustments, HTLC operations, ...)
The text was updated successfully, but these errors were encountered: