Store the announcement_signature in the database to work around some impls not sending it on reconnect

[cdecker]

Proposed by @SimonVrouwe here.

This should reduce the number of "Waiting for their announcement signature" channels dramatically.

[trueptolemy]

If you don't hurry, I want to have a try.

[cdecker]

Absolutely, go ahead. I can't add you as assignee until you accept my collaborator invitation, but consider yourself the owner of this issue 😉

[trueptolemy]

Absolutely, go ahead. I can't add you as assignee until you accept my collaborator invitation, but consider yourself the owner of this issue

thank u :) !

[jb55]

yikers, I haven't looked at my lightning node in awhile and saw this:

[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Channel announced."
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[]
[
  "CHANNELD_NORMAL:Attempting to reconnect"
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Attempting to reconnect"
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Attempting to reconnect"
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Channel announced."
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Reconnected, and reestablished.",
  "CHANNELD_NORMAL:Funding transaction locked. Waiting for their announcement signatures."
]
[
  "CHANNELD_NORMAL:Funding transaction locked. Channel announced."
]

[niftynei]

@jb55 i'm not sure what i'm looking at here. are these all in the same channel status, or did you edit it the output to condense it to just the statuses?

[jb55]

yeah sorry that was just lightning-cli listpeers | jq '.peers[] | .channels[].status'

I noticed with lnvis that all my channels were closed, and all my peers have these statuses. thought that was strange and found this and related issues.

[jb55]

Actually I'm not sure if they're "closed", but they're not in the listchannels?

[niftynei]

if they're waiting for announcement signatures they won't be 'announced' (no channel_announcement is sent), which means there's no record of them in gossip, which means they won't show up as available for routing in any other nodes' routemap. i believe listchannels pulls from gossip, which would explain why it's not there either.

[jb55]

yeah none of my channels are getting announced because of this. will try #2619