From 4e77168c6d62c5e9b290071ff2290aa26abf1706 Mon Sep 17 00:00:00 2001 From: Christian Decker Date: Thu, 26 Jan 2023 15:21:02 +0100 Subject: [PATCH] gossipd: Do not send warning when node_announcement parsing fails Changelog-Fixed: gossip: We removed a warning for old `node_announcement` that was causing LND peers to disconnect --- gossipd/routing.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gossipd/routing.c b/gossipd/routing.c index bae5e2b8ba9d..3df90bdc602b 100644 --- a/gossipd/routing.c +++ b/gossipd/routing.c @@ -1848,10 +1848,12 @@ u8 *handle_node_announcement(struct routing_state *rstate, const u8 *node_ann, * - MAY close the connection. * - MUST NOT process the message further. */ - u8 *warn = towire_warningfmt(rstate, NULL, - "Malformed node_announcement %s", - tal_hex(tmpctx, node_ann)); - return warn; + /* FIXME: We removed a warning about the + * node_announcement being malformed since the warning + * could cause lnd to disconnect (seems they treat + * channel-unrelated warnings as fatal?). + */ + return NULL; } sha256_double(&hash, serialized + 66, tal_count(serialized) - 66);