All peg-out related detection pushes should be <= OP_PUSHDATA4 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if you intend to do this in a follow-up PR, but |
|
Ah, good point. |
|
LGTM |
|
LGTM. |
instagibbs
added a commit
that referenced
this pull request
Jun 5, 2019
…DATA4 cff50f5 All peg-out related detection pushes should be <= OP_PUSHDATA4 (Gregory Sanders) Pull request description: related to #598 , #596, #597 This does not affect consensus, but affects consumers of these parsing rules such as rust-elements. cc @apoelstra @roconnor-blockstream Tree-SHA512: 4ab6f0be52c3804b2af43c7b3eecbbe8f2868d3f33385dc54f3acb0e441188018a2b3df197801f2c20fa96e224b6acacb642ecf2f030227618e0aea1e2da44ea
This was referenced Jun 5, 2019
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 3, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
gwillen
pushed a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #598 , #596, #597
This does not affect consensus, but affects consumers of these parsing rules such as rust-elements.
cc @apoelstra @roconnor-blockstream