-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Drawer, a new component, has a small problem: the default value of the appendToBody attribute in the document is false, but the default value in the code is true, the modal-append-to-body attribute in the document is not working well, it seems that the props in the code is not received. #16783
Comments
Translation of this issue: Element UI version2.11.1 OS/Browsers versionChrome 69.0.3497.92 Vue version2.6.10 Reproduction LinkHttps://codepen.io/minions 51390/pen/aepEpj Steps to reproduceClick on the button and set the modal-append-to-body attribute to false. It is found that the DOM is still append to the body. In this link, I did not set the append-to-body attribute. According to the document, the default value of append-to-body is false. Then the drawer's DOM should be append to the div named drawer-wrapper, but still append to the body. What is Expected?When the modal-append-to-body attribute is set to false, DOM is added to the parent element of Drawer. What is actually happening?The modal-append-to-body attribute does not seem to be in effect. Without setting the append-to-body attribute, DOM will be added to the body. |
The modal and modal-append-to-body attributes don't work. |
@JeremyWuuuuu 看一下。 |
@ziyoung Got it. |
@Minions51390 @cuevven It's a bug, which will be fixed @ next release. I am so sorry for the bug. |
@JeremyWuuuuu 辛苦修复,超喜欢elementUI,很棒很棒的组件库~ |
@Minions51390 感谢! |
#16953 |
Element UI version
2.11.1
OS/Browsers version
Chrome 69.0.3497.92
Vue version
2.6.10
Reproduction Link
https://codepen.io/minions51390/pen/aepEpj
Steps to reproduce
点击按钮,设置modal-append-to-body属性为false后发现dom依然被append到了body里面,
这个链接里面我没有设置append-to-body属性,按照文档上说明append-to-body默认值为false,那么drawer的dom应该被append到class名为drawer-wrapper的div下面但是依旧被append到body下面。
What is Expected?
设置modal-append-to-body属性为false后,dom会被添加到Drawer 的父元素上。
不设置append-to-body属性,dom会被添加到Drawer 的父元素上。
What is actually happening?
modal-append-to-body属性好像没有生效。
不设置append-to-body属性,dom会被添加body上面。
The text was updated successfully, but these errors were encountered: