Skip to content

Commit

Permalink
InfiniteScroll: Skip trigger event on invisible element (#17553)
Browse files Browse the repository at this point in the history
* InfiniteScroll: Do not trigger event on invisible element

* InfiniteScroll: Do not trigger event on invisible element2
  • Loading branch information
iamkun authored and island205 committed Oct 31, 2019
1 parent 0c31a0a commit 6f62fee
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/infinite-scroll/src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ const handleScroll = function(cb) {

if (disabled) return;

const containerInfo = container.getBoundingClientRect();
if (!containerInfo.width && !containerInfo.height) return;

let shouldTrigger = false;

if (container === el) {
Expand Down
26 changes: 26 additions & 0 deletions test/unit/specs/infiniteScroll.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,31 @@ describe('InfiniteScroll', () => {
await wait();
expect(vm.$el.innerText.indexOf('2') > -1).to.be.true;
});

it('invisible element not trigger', async() => {
vm = createVue({
template: `
<div v-show="false">
<ul ref="scrollTarget" v-infinite-scroll="load" style="height: 300px;overflow: auto;">
<li v-for="i in count" style="display: flex;height: 50px;">{{ i }}</li>
</ul>
</div>
`,
data() {
return {
count: 0
};
},
methods: {
load() {
this.count += 2;
}
}
}, true);
vm.$refs.scrollTarget.scrollTop = 2000;
await wait();
expect(vm.$el.innerText.indexOf('2') > -1).to.be.false;
});

});

0 comments on commit 6f62fee

Please sign in to comment.