-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Sample data are inconsistent #219
Comments
That's super interesting. They were all generated with the same codebase and same primes recently. Is this referring to what's include in the zip or what's included in the raw folders? |
@JohnLCaron can you double check me and look and see how we're serializing in Python to doublecheck there isn't something fishy about the BigInt serialization in terms of |
We can likely do something post 1.4 where we rebuild the entire set of sample data at that juncture and only include the manifests in here. I think that's the simplest solution. |
ok, the constants are ok now. however, the coefficients.json files seem wrong, and different than what I get when i run TestEndToEndElection on python library HEAD: my run
what i see in electionguard/data/0.95.0/sample/hamilton-general/election_record/coefficients.json (actually all the sample files):
|
Since 0.95 data are now inconsistent with 1.0, Im removing my tests on 0.95 data and closing this issue. |
Is there an existing issue for this?
Current Behavior
electionguard/data/0.95.0/sample data
uses base10 or base16 for encoding bigintegers
sometimes use current primes, sometimes previous ones
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- OS:
Anything else?
No response
The text was updated successfully, but these errors were encountered: