Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Sample data are inconsistent #219

Closed
1 task done
JohnLCaron opened this issue Feb 14, 2022 · 5 comments
Closed
1 task done

🐞 Sample data are inconsistent #219

JohnLCaron opened this issue Feb 14, 2022 · 5 comments
Labels
bug Something isn't working triage Waiting to be triaged

Comments

@JohnLCaron
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

electionguard/data/0.95.0/sample data

uses base10 or base16 for encoding bigintegers
sometimes use current primes, sometimes previous ones

                             bigint   constants
                             --------  ------------ 
full                         base10   standard
hamilton-general             base16   ?
minimal                      base10  previous
small                        base10  previous

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:

Anything else?

No response

@JohnLCaron JohnLCaron added bug Something isn't working triage Waiting to be triaged labels Feb 14, 2022
@keithrfung
Copy link
Collaborator

keithrfung commented Feb 16, 2022

That's super interesting. They were all generated with the same codebase and same primes recently. Is this referring to what's include in the zip or what's included in the raw folders?

@keithrfung
Copy link
Collaborator

@JohnLCaron can you double check me and look and see how we're serializing in Python to doublecheck there isn't something fishy about the BigInt serialization in terms of base16 vs base10. They should all be using the new primes and base16 aka hex for serialization.

@keithrfung
Copy link
Collaborator

We can likely do something post 1.4 where we rebuild the entire set of sample data at that juncture and only include the manifests in here. I think that's the simplest solution.

@JohnLCaron
Copy link
Collaborator Author

JohnLCaron commented Mar 10, 2022

ok, the constants are ok now.

however, the coefficients.json files seem wrong, and different than what I get when i run TestEndToEndElection on python library HEAD:

my run

{
  "coefficients": {
    "1": {
      "data": "05"
    },
    "2": {
      "data": "FFE7"
    },
    "3": {
      "data": "0A"
    },
    "4": {
      "data": "FFEC"
    },
    "5": {
      "data": "01"
    }
  }
}

what i see in electionguard/data/0.95.0/sample/hamilton-general/election_record/coefficients.json (actually all the sample files):

{
  "coefficients": [
    {
      "data": "03"
    },
    {
      "data": "FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF40"
    },
    {
      "data": "01"
    }
  ]
}

@colleenirt colleenirt added the triage Waiting to be triaged label Apr 11, 2022
@JohnLCaron
Copy link
Collaborator Author

Since 0.95 data are now inconsistent with 1.0, Im removing my tests on 0.95 data and closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Waiting to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants