added range Chaum-Pedersen proofs and eliminated placeholders #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alization; fixed bug with determining limit of range proofs
…ictionaries to (flattened) list; all tests now pass, and disjunctive Chaum-Pedersen proofs are now unused
…erencing the specification for clarity of use
…oved placeholders
…tionguard-python into cumulative-voting
…erencing the specification for clarity of use
…oved placeholders
SteveMaier-IRT
merged commit e33e830
into
Election-Tech-Initiative:feature/cumulative-voting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #760
Description
This pull requests creates range Chaum-Pedersen proofs and replaces disjunctive and constant Chaum-Pedersen proofs in use for selection limits and contest limits, respectively. Then, it removes placeholder selections from ElectionGuard. Unit testing is included.
Finally, cumulative voting is added with testing. Support for cumulative voting is a matter of defining contests by
votes_allowedandvotes_allowed_per_selection, noticing thatnumber_electedis redundant. Thevotes_alloweddetermines the maximum count of votes each ballot may allot across the entire contest;votes_allowed_per_selectiondetermines the maximum count of votes each ballot may allot to any particular selection in the contest. Some common contest types and their corresponding values include:votes_allowed = n,votes_allowed_per_selection = 1,votes_allowed = n,votes_allowed_per_selection = n,votes_allowed = m,votes_allowed_per_selection = 1.Testing
This builds as expected. Unit tests were adapted for the range Chaum-Pedersen proofs and elimination of placeholders as well as added for sample cumulative voting contests.