Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔍. Add lgtm.yml for better checking of code #196

Open
4 tasks
keithrfung opened this issue Sep 2, 2021 · 3 comments
Open
4 tasks

🔍. Add lgtm.yml for better checking of code #196

keithrfung opened this issue Sep 2, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues for the Hacktoberfest help wanted Extra attention is needed

Comments

@keithrfung
Copy link
Collaborator

keithrfung commented Sep 2, 2021 •
edited
Loading

Issue

Description
Create a lgtm.yml file to correctly check the C++ and C# code.

As it currently stands the lgtm tool defaultly cannot check the library
Screen Shot 2021-09-02 at 3 11 47 PM

  • Create lgtm.yml
  • Add C++ rules to yaml to ensure make build is checked
  • Add C# rules to ensure .NET Standard C# code is checked
  • Update CodeQL workflow

This can be checked at lgtm.com.

Example would be:

extraction:
  cpp:
      index:
  csharp:
      index:
@keithrfung keithrfung added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 2, 2021
@keithrfung keithrfung added the hacktoberfest Issues for the Hacktoberfest label Sep 15, 2021
@mihir1739
Copy link

Please assign this to me ..

@keithrfung
Copy link
Collaborator Author

@mihir1739 you got it!

@keithrfung
Copy link
Collaborator Author

@mihir1739 Unassigning since there was no followup. Feel free to reply if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keithrfung @mihir1739