Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement 400 excpetion on deserialization failure #226

Closed
wants to merge 2 commits into from
Closed

implement 400 excpetion on deserialization failure #226

wants to merge 2 commits into from

Conversation

gagandeepp
Copy link

@gagandeepp gagandeepp commented Oct 4, 2022 •
edited
Loading

Issue

Fixes #99

Description

Add raise exception clause with 400 status for the deserialisation failure

Testing

Hit Post Encrypt endpoint with incorrect request model

@gagandeepp
Copy link
Author

@keithrfung please review

lprichar
lprichar previously approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@lprichar lprichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@lprichar
Copy link
Collaborator

lprichar commented Oct 4, 2022

@gagandeepp please fix linting error

@gagandeepp
Copy link
Author

@lprichar can you please review this?
If you are facing issue while reviewing please add HACKTOBERFEST-ACCEPTED label to the issue ,so that you can review this later

@gagandeepp
Copy link
Author

@lprichar please review this

@gagandeepp gagandeepp requested review from lprichar and removed request for lprichar October 7, 2022 12:05
@gagandeepp
Copy link
Author

@lprichar pleae review

@gagandeepp gagandeepp closed this by deleting the head repository May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lprichar lprichar Awaiting requested review from lprichar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return 400 errors on deserialization failure
2 participants
@gagandeepp @lprichar