-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve upgrader documentation regarding protocols #13
Comments
Originial Comment: @marti1125 It looks like you added a Sec-WebSocket-Extensions header, but that header is unrelated to subprotocols. Did you you intend to add a Sec-Websocket-Protocol instead? |
Originial Comment: @IngCr3at1on Hi, @marti1125 yes absolutely! Documentation contributions are always welcome assuming they're clear and concise; my vote, feel free to open a pull request if you have documentation you believe would be useful. |
This comment was marked as outdated.
This comment was marked as outdated.
Originial Comment: @marti1125 I am trying to understand subprotocols using client/server example I just modify https://github.com/gorilla/websocket/blob/master/examples/echo/server.go#L23
in the terminal show |
Orginal Comment: @ghost @marti1125 It looks like you added a Sec-WebSocket-Extensions header, but that header is unrelated to subprotocols. Did you you intend to add a Sec-Websocket-Protocol instead? |
From websocket created by garyburd: gorilla#404
Points to cover
Subprotocols(r *http.Request) []string
function is helpful here.The text was updated successfully, but these errors were encountered: