Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deth_ctf: Deployer won't be able to retrieve the actual address of the created vault #47

Open
Zinda-Lukman opened this issue Aug 15, 2024 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Zinda-Lukman
Copy link

In factory::deployVault when creating a new vault, the address of the created vault is stored in a memory variable vaultAddress which is destroyed after function execution and deployer won't be able to retrieve the actual created address.

The lastDeployed variable would have been user to store this address but it not stored their.

impact

User won't be able to know the address of their vaults that they created.

recommendation

Consider storing the new address in the lastDeployed variable so that users can access it.

@0xdeth 0xdeth added bug Something isn't working duplicate This issue or pull request already exists labels Aug 17, 2024
@0xdeth
Copy link
Contributor

0xdeth commented Aug 17, 2024

Duplicate of #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants