Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpApi: transformClient does not support composition with e.g. HttpClient.retry #3715

Open
fubhy opened this issue Oct 1, 2024 · 1 comment · May be fixed by #3794
Open

HttpApi: transformClient does not support composition with e.g. HttpClient.retry #3715

fubhy opened this issue Oct 1, 2024 · 1 comment · May be fixed by #3794
Labels
bug Something isn't working

Comments

@fubhy
Copy link
Member

fubhy commented Oct 1, 2024

What version of Effect is running?

No response

What steps can reproduce the bug?

It'd appear that adding a generic retry handler in the transformClient phase is not supported because the response handling of HttpApi is added later.

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response

@fubhy fubhy added the bug Something isn't working label Oct 1, 2024
@fubhy
Copy link
Member Author

fubhy commented Oct 1, 2024

In general I'd argue that the HttpApi and the HttpClient api are clashing a little bit in the transformClient code path. The interplay of HttpClient.retry, HttpClient.filter*, etc. with the underlying HttpApi declaration only becomes clear when following the implementation of HttpApiClient.make all the way.

I don't have any better suggestions so far but somehow this doesn't feel perfect yet :-)

@tim-smart tim-smart linked a pull request Oct 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant