Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring SMD code/changing documentation. #489

Open
aloukina opened this issue Nov 12, 2020 · 0 comments
Open

Consider refactoring SMD code/changing documentation. #489

aloukina opened this issue Nov 12, 2020 · 0 comments

Comments

@aloukina
Copy link
Collaborator

Currently SDM/DSM is computed in utils.metrics but the parameters for computation are passed through two more functions in analyzer leading to confusing and repetitive documentation and making it difficult to track which parameters are obligatory. We should either consider if it's possible to re-factor the code or revise documentation to point to the SMD method,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aloukina